-
Notifications
You must be signed in to change notification settings - Fork 3
feat(widget): scope dashboard yield discovery by category #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
packages/widget/src/hooks/api/use-dashboard-yield-catalog.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| import { useQueries } from "@tanstack/react-query"; | ||
| import { useMemo } from "react"; | ||
| import type { TokenDto } from "../../domain/types/tokens"; | ||
| import { | ||
| type DashboardYieldCategory, | ||
| dashboardYieldCategories, | ||
| getApiYieldTypesForDashboardCategory, | ||
| } from "../../domain/types/yields"; | ||
| import { useApiClient } from "../../providers/api/api-client-provider"; | ||
| import { useSKWallet } from "../../providers/sk-wallet"; | ||
| import { | ||
| DEFAULT_YIELD_SUMMARIES_PAGE_LIMIT, | ||
| fetchYieldSummariesPage, | ||
| getYieldSummariesQueryKey, | ||
| isVisibleYieldSummary, | ||
| type YieldSummariesParams, | ||
| } from "./use-yield-summaries"; | ||
|
|
||
| type DashboardCategoryInitialSelection = { | ||
| token: TokenDto; | ||
| yieldId: string; | ||
| }; | ||
|
|
||
| const staleTime = 1000 * 60 * 2; | ||
|
|
||
| /** | ||
| * Discovers available dashboard earn categories with one network-scoped, | ||
| * reward-rate-sorted probe per category (no dependency on the wallet's token | ||
| * holdings, no per-yield legacy hydration). The first visible summary of each | ||
| * probe seeds that category's initial token + yield selection. | ||
| */ | ||
| export const useDashboardYieldCatalog = ({ | ||
| enabled = true, | ||
| }: { | ||
| enabled?: boolean; | ||
| } = {}) => { | ||
| const { network } = useSKWallet(); | ||
| const apiClient = useApiClient(); | ||
|
|
||
| const probeEnabled = enabled && !!network; | ||
|
|
||
| const results = useQueries({ | ||
| queries: dashboardYieldCategories.map((category) => { | ||
| const params: YieldSummariesParams = { | ||
| network: network ?? undefined, | ||
| types: getApiYieldTypesForDashboardCategory(category), | ||
| sort: "rewardRateDesc", | ||
| limit: DEFAULT_YIELD_SUMMARIES_PAGE_LIMIT, | ||
| }; | ||
|
|
||
| return { | ||
| enabled: probeEnabled, | ||
| staleTime, | ||
| queryKey: getYieldSummariesQueryKey(params), | ||
| queryFn: ({ signal }: { signal: AbortSignal }) => | ||
| fetchYieldSummariesPage({ apiClient, params, signal }), | ||
| }; | ||
| }), | ||
| }); | ||
|
|
||
| return useMemo(() => { | ||
| const initialSelectionByCategory = new Map< | ||
| DashboardYieldCategory, | ||
| DashboardCategoryInitialSelection | ||
| >(); | ||
| const availableCategories: DashboardYieldCategory[] = []; | ||
|
|
||
| dashboardYieldCategories.forEach((category, index) => { | ||
| const firstVisible = (results[index]?.data ?? []).find( | ||
| isVisibleYieldSummary | ||
| ); | ||
|
|
||
| if (!firstVisible) return; | ||
|
|
||
| availableCategories.push(category); | ||
| initialSelectionByCategory.set(category, { | ||
| token: firstVisible.token, | ||
| yieldId: firstVisible.id, | ||
| }); | ||
| }); | ||
|
|
||
| return { | ||
| availableCategories, | ||
| initialSelectionByCategory, | ||
| isLoading: probeEnabled && results.some((result) => result.isLoading), | ||
| }; | ||
| }, [results, probeEnabled]); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single-page probing can falsely mark categories as unavailable.
Line 55 fetches only one page (Line 48 limit), and Line 69 searches visibility only within that page. If visible yields start after the first page, the category is incorrectly hidden and no initial selection is seeded.
💡 Suggested fix
import { DEFAULT_YIELD_SUMMARIES_PAGE_LIMIT, + fetchAllYieldSummaries, fetchYieldSummariesPage, getYieldSummariesQueryKey, isVisibleYieldSummary, type YieldSummariesParams, } from "./use-yield-summaries"; @@ return { enabled: probeEnabled, staleTime, - queryKey: getYieldSummariesQueryKey(params), + queryKey: getYieldSummariesQueryKey({ ...params, allPages: true }), queryFn: ({ signal }: { signal: AbortSignal }) => - fetchYieldSummariesPage({ apiClient, params, signal }), + fetchAllYieldSummaries({ apiClient, params, signal }), }; }), });Also applies to: 68-74
🤖 Prompt for AI Agents