Clarify SW103 migration with concrete examples and keyed-only registration guidance - #2
Merged
cliedeman merged 4 commits intoMay 31, 2026
Conversation
Copilot created this pull request from a session on behalf of
cliedeman
May 31, 2026 10:45
View session
cliedeman
reviewed
May 31, 2026
| ```ini | ||
| [*.cs] | ||
| dotnet_diagnostic.SW103.severity = error | ||
| ``` |
Contributor
There was a problem hiding this comment.
add some migration samples to the repo.
DI callsites and AddAzureClients config
Contributor
Author
There was a problem hiding this comment.
Done — added four concrete code samples to the Migration Notes section:
- Registration before — full
AddAzureClientsblock with two named clients (blob-storage,order-queue) and configuration sections. - Registration after — equivalent
AddKeyedSingletonregistrations using connection strings, noMicrosoft.Extensions.Azureimport. - DI callsite before — constructor injection via
IAzureClientFactory<BlobServiceClient>+CreateClient("blob-storage"). - DI callsite after — constructor injection using
[FromKeyedServices("blob-storage")]attribute.
Copilot
AI
changed the title
Add SW103 analyzer to ban Microsoft.Extensions.Azure and document keyed-service migration
docs(SW103): add concrete AddAzureClients → keyed services migration samples
May 31, 2026
Copilot
AI
changed the title
docs(SW103): add concrete AddAzureClients → keyed services migration samples
Clarify SW103 migration with concrete examples and keyed-only registration guidance
May 31, 2026
cliedeman
approved these changes
May 31, 2026
cliedeman
marked this pull request as ready for review
May 31, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates SW103 documentation to directly address migration ambiguity called out in review feedback. The rule guidance now shows exactly how to move from
Microsoft.Extensions.Azurepatterns to keyed DI and explicitly discourages fallback unkeyed registrations.Migration examples added
AddAzureClients(...).WithName(...)usageIAzureClientFactory<T>.CreateClient("key")[FromKeyedServices("key")]constructor injectionKeyed-only preference made explicit