SIP-039: Clarity 5 and Epoch 3.4 - #256
Conversation
Originally, this was going to be epoch-gated, but it makes more sense to keep the existing behavior in existing contracts and only fix it in new versions of Clarity.
|
There are a few more changes that we are considering adding into this epoch, so I'm not requesting the Technical CAB review quite yet. Will update here when it is final. 🙏 |
|
This looks great to me! Will approve once the (very minor) comments are addressed |
|
@brice-stacks can you move the files into the expected structure? |
Co-authored-by: wileyj <2847772+wileyj@users.noreply.github.com>
Co-authored-by: wileyj <2847772+wileyj@users.noreply.github.com>
Indeed this is something that needs to be clarified. however, since the current text of sip-000 is already ratified and any changes made there will likely not impact this SIP - we're left with applying the standards that are set currently. @behaddy @Hero-Gamer - This is something i have been working to codify in an update to sip-000, but i think it's out of scope for this PR (but i have indeed been thinking about it - there are definitely cases where a hard fork is needed to change/fix something that may not require a public vote). The reasoning for the activation section in this PR, which i shared with @brice-stacks was from the text here: https://github.com/stacksgov/sips/blob/main/sips/sip-000/sip-000-stacks-improvement-proposal-process.md#voting-on-technical-sips Even though we have usually held a public vote for hard forks, I felt in this case based on the above language and there being no breaking changes or backward compatibility issues - a CAB vote is sufficient. I would also address precedent here - there have been hard forks in the past where a public vote was not held, only a CAB vote. Typically, we have left these decisions up to SIP authors (for better or worse), and anyone may argue that this does require a public vote (and even suggest that change to this SIP). But, based on the current sip-00 requirements, I don't think it's a hard requirement. In my opinion, because the changes here are backwards compatible, are meant to resolve open issues in Clarity, and ultimately are "opt-in", I would argue that a public vote here should not be a hard requirement. But again, each proposal should be scrutinized for when a public vote should be held (i.e. a hard fork to change POX, i would argue that a public vote should be held since it would directly impact any POX users), but there really isn't something we can point to that tells us when a public vote is required vs when it's suggested vs when it's not needed. |
Used to generate addresses for voting. See README for details.
This reverts commit 8fb11a0.
314159265359879
left a comment
There was a problem hiding this comment.
Looks good to me
|
|
||
| - Brice Dobry <brice@stackslabs.com> | ||
|
|
||
| Status: Activation-In-Progress |
There was a problem hiding this comment.
this sip is Ratified, change this line before merging?
This specifies a smaller hard-fork needed to solve some incorrect behavior in Clarity. These changes are consensus-breaking but they do not change the intended behavior described in previous SIPs. They only fix bad behavior or under-specified behavior that makes the network worse the way it is currently implemented. For those reasons, I think this should not require a community vote, but just Technical CAB and Steering Committee approvals.