Surface StorageVersionMigrator behind chart feature flag (opt-in)#5418
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5418 +/- ##
==========================================
+ Coverage 68.76% 68.77% +0.01%
==========================================
Files 629 629
Lines 63937 63937
==========================================
+ Hits 43964 43972 +8
+ Misses 16721 16712 -9
- Partials 3252 3253 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds an opt-in chart value (`operator.features.storageVersionMigrator`, default `false`) and wires `TOOLHIVE_ENABLE_STORAGE_VERSION_MIGRATOR` into the operator deployment. helm-docs README regenerated. The controller (PR-A, #5362) and the opt-in labels + CI guard (PR-B, #5391) are on main. This PR is the chart-side surface that lets operators opt in via `helm install --set` or values.yaml. Reference and upgrade-guide docs are intentionally separate — they land in a follow-up PR. Closes #4969. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ff9a780 to
cf9c977
Compare
JAORMX
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes the StorageVersionMigrator controller (PR-A, #5362) to operator users via a new helm chart feature flag.
The feature stays opt-in via the chart value (default
false). Admins who want auto-migration setoperator.features.storageVersionMigrator: trueat install or upgrade time. A future release can flip the default if/when we want the feature on by default — that flip is intentionally a separate decision.User-facing reference docs and the upgrade-guide walkthrough are deliberately not in this PR — they land separately.
Part of #4969. Depends on #5362 (merged) and #5391 (merged).
Medium level
operator.features.storageVersionMigratorvalue indeploy/charts/operator/values.yaml, defaulting tofalse. helm-docs comment explains what the feature does — no temporal claims about when the default might change.deployment.yamlwiresTOOLHIVE_ENABLE_STORAGE_VERSION_MIGRATORenv var from the chart value.deploy/charts/operator/README.mdregenerated bytask helm-docsto reflect the new value.cmd/thv-operator/app/app.go'sisStorageVersionMigratorEnabled()staysfalse— chart-level opt-in is sufficient for helm-installed operators, and keeping the operator-code default unchanged matches PR-A's posture.Low level
deploy/charts/operator/values.yamloperator.features.storageVersionMigrator: falsevalue (+6 lines)deploy/charts/operator/templates/deployment.yamlTOOLHIVE_ENABLE_STORAGE_VERSION_MIGRATOR(+2 lines)deploy/charts/operator/README.mdType of change
Test plan
task buildcleanhelm lint deploy/charts/operatorcleantask helm-docsproduces no further diff after the value is addedTOOLHIVE_ENABLE_STORAGE_VERSION_MIGRATORenv var wiring matches the constant the controller reads incmd/thv-operator/app/app.goWhy default
falseOpt-in posture for one release:
helm upgradeget a behavioural change they didn't anticipate.A future release will flip the chart default to
true. That flip is intentionally a separate decision.Follow-ups (separate PRs / issues)
app/app.go(paired with the chart-default flip).if .Values.operator.features.storageVersionMigrator).MigrationStuckCondition + Warning event for better SRE visibility.crs_processed_total,reconcile_duration_seconds,cache_size,consecutive_conflict_passes).Generated with Claude Code