Expose strict VirtioFS ownership preparation - #127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose virtiofs.PrepareOwnership(ctx, root, relativePath, uid, gid) for strict full-tree or targeted preparation using the existing override_stat mechanism. Startup and explicit calls share one descriptor-relative, symlink-confined implementation.
Startup policy and compatibility
Lifecycle and caller obligations
Public examples/tests cover snapshot preparation before explicit host sealing, worktrees prepared before consumer-level registration under an existing export, and synchronized post-merge replacements. Preparing at host mode 0600 then sealing to 0400 retains guest mode 0600; read-only export enforcement still denies guest writes.
Writing xattrs requires OS permission: an unannotated 0400 file normally returns a permission error for an unprivileged caller. No copying, staging subsystem, chmod/chown widening, watcher, or new mode-setting API is introduced.
Keep export roots stable, authorize hard-linked inodes, and synchronize host changes and guest metadata changes/access. Preparation is nontransactional and does not invalidate guest caches.
Validation
Local full CGO checks require unavailable libkrun.pc; repository CI covers Linux/macOS builds/tests. No live Apple Silicon guest behavior is claimed.
Release notes
See docs/RELEASE_NOTES.md. Not released; follow normal reviewed merge and tag-triggered release process.