WIP: Add support for MutableCSINodeAllocatableCount#1066
Draft
WIP: Add support for MutableCSINodeAllocatableCount#1066
Conversation
|
Skipping CI for Draft Pull Request. |
ske-prow
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ske-prow
Bot
added
do-not-merge/needs-kind
The CSI list's all PCIe devices that are not of type VIRTIO_BLOCK_DEVICE and subtracts them from the theoretically maximum, so kubernetes can report a correct dynamic max volume count that can be attached for each node. Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
Signed-off-by: Niclas Schad <niclas.schad@stackit.cloud>
nschad
force-pushed
the
dynamic-volume-limits
branch
from
c9ac70a to
127f8d7
Compare
nschad
changed the title
nschad
changed the title
Contributor
Author
|
/kind enhancement /hold waiting for IaaS to clarify some API endpoints |
ske-prow
Bot
added
kind/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
This PR updates the CSI driver to dynamically calculate the maximum allocatable volume count when the MutableCSINodeAllocatableCount feature gate is enabled.
Instead of relying on a static limit, the driver now scans the system for existing PCIe devices and subtracts them from the instance type's theoretical maximum PCIe lane capacity. This ensures that hardware overhead—such as additional Network Interface Cards (NICs)—is accounted for, preventing volume attachment failures due to exhausted root ports.
This will also lead to better scheduling decision by the kube-scheduler.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: