Skip to content

Release workflow: drop reserved GITHUB_ env overrides - #4

Merged
sks merged 1 commit into
mainfrom
fix-release-reserved-env
Nov 11, 2026
Merged

sks merged 1 commit into
mainfrom
fix-release-reserved-env

Conversation

@sks

@sks sks commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

What

Removes the GITHUB_SHA / GITHUB_REF_NAME step-env overrides from the Release workflow's "Cut release" step.

The GITHUB_ prefix is reserved for GitHub-provided variables; the runner already sets GITHUB_SHA (dispatched ref's HEAD), GITHUB_REPOSITORY, and GITHUB_REF_NAME to exactly the values the script requires, so the overrides are unnecessary and against documented usage.

Honest framing

The original dispatch of the Release workflow (and a follow-up on this branch) failed with startup_failure, and I initially blamed these overrides. A bisect then showed even a minimal workflow_dispatch + echo workflow failed the same way, so the trigger failures were caused by the org-side "Actions cannot trigger pipelines" condition, not this file — the override was masked, not proven guilty. Still, removing it is correct per the reserved-prefix docs, and one fewer thing to rule out when Actions is healthy again.

Verified

  • actionlint .github/workflows/release.yml clean.
  • cut-release.sh --dry-run against current main still derives v0.2.0 with identical notes (the script reads GITHUB_SHA/GITHUB_REPOSITORY from runner defaults, which is what it always required).
  • v0.2.0 was cut manually (repo-side, no Actions) from a0cbdcc using this same script — tags, moving v1, release notes all correct: https://github.com/stackgenhq/cce-action/releases/tag/v0.2.0

After merge

Once the org's Actions triggering works again, dispatching the Release workflow on main should go through the green-Self-test gate and the normal path; this change removes a reserved-env footgun from that path.

workflow_dispatch runs failed with startup_failure (run 43095373081)
because the Cut release step set GITHUB_SHA and GITHUB_REF_NAME in its
env block; the GITHUB_ prefix is reserved. The runner defaults already
carry exactly those values for the dispatched ref, so drop the overrides.

The cut-release.sh script reads GITHUB_SHA / GITHUB_REPOSITORY from the
runner defaults, which is what it required all along.
@sks
sks merged commit 73e9e84 into main Nov 11, 2026
@sks
sks deleted the fix-release-reserved-env branch November 13, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant