Fix quote toggling around code blocks#3138
Closed
zhailong8845-art wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2862
What changed
When quote formatting is toggled off, unwrap selected top-level quote nodes instead of converting their nested blocks to paragraphs. This preserves nested code blocks and any other child block types while maintaining their order.
Tests
npx jest lib/lexical/commands/formatting/blocks.test.js --runInBand(2 passing)npx standard lib/lexical/commands/formatting/blocks.js lib/lexical/commands/formatting/quote.js lib/lexical/commands/formatting/blocks.test.jsgit diff --checkThe regression tests cover the quoted-code reproduction and a mixed code/paragraph quote to ensure unwrapping preserves both type and order.