Skip to content

fix: watch s3 connection for changes - #765

Merged
sweb merged 2 commits into
mainfrom
fix/watch-s3-con
Oct 1, 2026
Merged

sweb merged 2 commits into
mainfrom
fix/watch-s3-con

Conversation

@sweb

@sweb sweb commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Description

Previously, the s3 connection was not watched - now a change to the s3 connection triggers a reconcile. This is also open for Trino and Spark.

In addition, the config map watch gets a check to restrict to the hive cluster's namespace.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Comment thread rust/operator-binary/src/main.rs
@sweb
sweb force-pushed the fix/watch-s3-con branch 2 times, most recently from 073f238 to bd17c89 Compare September 11, 2026 08:54
@sweb sweb moved this to Development: Waiting for Review in Stackable Engineering Sep 11, 2026
@sweb sweb self-assigned this Sep 11, 2026
Comment thread rust/operator-binary/src/main.rs

@sbernauer sbernauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bug, thx! I pitched a idea how to solve this with a general, generic approach, but we want to fix the bug anyway now

Comment thread rust/operator-binary/src/main.rs
@sweb
sweb added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit ba94522 Oct 1, 2026
21 of 23 checks passed
@sweb
sweb deleted the fix/watch-s3-con branch October 1, 2026 08:13
@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Oct 19, 2026
@lfrancke

Copy link
Copy Markdown
Member

Please add a release note snippet in the form "Previously, this went wrong. With this release, this was fixed in the following way."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Acceptance: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants