Skip to content

fix: stop run mode tooltip from widening the Trino page - #433

Merged
Bohreromir merged 1 commit into
mainfrom
fix/run-button-tooltip-overflow
Oct 30, 2026
Merged

Bohreromir merged 1 commit into
mainfrom
fix/run-button-tooltip-overflow

Conversation

@Bohreromir

Copy link
Copy Markdown
Member

The hidden tooltip of the run mode toggle is still laid out. Centred below the button at the right edge, it overflowed

by a few pixels and made the page scroll horizontally. Open it to the left instead.

Description

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

The hidden tooltip of the run mode toggle is still laid out. Centred
below the button at the right edge, it overflowed <main> by a few pixels
and made the page scroll horizontally. Open it to the left instead.
@Bohreromir
Bohreromir marked this pull request as ready for review October 30, 2026 15:11
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Oct 30, 2026
@Bohreromir Bohreromir self-assigned this Oct 30, 2026
@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.31% 9114 / 13540
🔵 Statements 66.28% 12276 / 18521
🔵 Functions 68.12% 2941 / 4317
🔵 Branches 57.33% 5152 / 8986
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/trino/RunButton.svelte 96.35% 84.31% 100% 97.33% 74-75, 89, 90, 111
Generated in workflow #1218 for commit 1495e5a by the Vitest Coverage Report Action

@lfrancke lfrancke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tried it out but I assume it fixes the scrollbar we saw earlier :)

@lfrancke lfrancke moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 30, 2026
@Bohreromir
Bohreromir added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 43cee53 Oct 30, 2026
12 checks passed
@Bohreromir
Bohreromir deleted the fix/run-button-tooltip-overflow branch October 30, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants