Repository navigation
Fix dev and pino logger - #432
Merged
Merged
Conversation
Since pino 10.4.0 the transport caller is detected via util.getCallSites(), which returns an empty script name for modules evaluated by Vite's SSR module runner. pino then cannot resolve 'pino-pretty' and `npm run dev` fails with "unable to determine transport target". Resolve the target to an absolute path ourselves. knip now sees pino-pretty as used, so drop it from ignoreDependencies.
A per-target `level` makes pino route logs through multistream, which since pino 10.4.0 warns about our custom `formatters.level` (PINO_TRANSPORT_MULTI_TARGETS_LEVEL_FORMATTER). A single target needs no level as the logger already filters. Keep it for multiple targets (LOG_JSON_FILE), where multistream would otherwise default targets to 'info' and drop debug logs.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
lfrancke
approved these changes
Oct 30, 2026
lfrancke
left a comment
lfrancke
left a comment
Member
There was a problem hiding this comment.
I already gave a demo with this so I know it works :) And from what I understand from the code it also looks fine. Thanks!
lfrancke
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated pino logger wants to be imported in a different way and broke our dev setup
Docs
Release note
Checklist
Author
Reviewer
Acceptance