Skip to content

Fix flaky tests and s3 kit warnings - #423

Merged
Bohreromir merged 3 commits into
mainfrom
fix-369-build-output
Oct 29, 2026
Merged

Bohreromir merged 3 commits into
mainfrom
fix-369-build-output

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Description

  • Remove a flaky test race condition
  • fixes s3 kit warnings

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

The AWS SDK sets no Content-Length for an empty string body and warns
about a stream of unknown length on every directory marker.
SvelteKit restores the URL of a cancelled popstate navigation with
history.go, so the leave warning can be visible before the URL is back.
This flaked on Firefox in CI.
Two workers provisioning the same bucket could both miss it in the
lookup and the second CreateBucket failed with 409. Look the bucket up
again when the creation fails.
@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 66.29% 8935 / 13478
🔵 Statements 65.11% 12025 / 18466
🔵 Functions 67.04% 2881 / 4297
🔵 Branches 56.58% 5164 / 9126
File CoverageNo changed files found.
Generated in workflow #1187 for commit 1d1aa64 by the Vitest Coverage Report Action

@Bohreromir Bohreromir self-assigned this Oct 28, 2026
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Oct 28, 2026
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 28, 2026
@Bohreromir
Bohreromir added this pull request to the merge queue Oct 29, 2026
@Bohreromir Bohreromir moved this from Development: In Review to Development: Done in Stackable Engineering Oct 29, 2026
Merged via the queue into main with commit dfbda26 Oct 29, 2026
10 checks passed
@Bohreromir
Bohreromir deleted the fix-369-build-output branch October 29, 2026 08:27
@Bohreromir Bohreromir linked an issue Oct 29, 2026 that may be closed by this pull request
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Review Build output

3 participants