Repository navigation
Bookmarks in DB - UI - #414
Merged
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bohreromir
force-pushed
the
feat-277-bookmarks-ui
branch
from
October 27, 2026 14:33
5e8b435 to
d1039c7
Compare
Bookmarks are loaded in the (app) layout and changed through the bookmarks API instead of localStorage. Without a signed-in user, or when loading them fails, the bookmark section is hidden. Closes #277
The layout load now tells a failed load apart from having no signed-in user. Without a user the section stays hidden; after a failure it says the bookmarks could not be loaded.
A failed request now reloads the list, e.g. after a change in another tab. A reload that fails after a saved change is retried once, then a toast offers a page reload instead of leaving the list stale.
A 409 shows the limit instead of a generic error, and a status region announces the save to screen readers while the spinner is shown.
Bohreromir
force-pushed
the
feat-277-bookmarks-ui
branch
from
October 27, 2026 15:32
d1039c7 to
68afd15
Compare
Bohreromir
marked this pull request as ready for review
October 27, 2026 15:51
1 task
…t-277-bookmarks-ui # Conflicts: # src/routes/(app)/+page.svelte
SvelteKit's invalidate() does not reject when the reload fails: it shows its error page and resolves. The retry and the "Reload" toast after a saved change therefore never ran, and their unit tests faked a rejection that does not happen. Verified with Playwright by failing __data.json after a successful save: one request, no toast, bare 500 page. When the server refuses a change, start the reload without awaiting it, so the dialog shows the error without waiting for the reload.
All sidebar tests seeded bookmarks and then loaded the page, so the invalidate path from a dashboard change to the layout's bookmarks was untested end to end.
dervoeti
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
dervoeti
approved these changes
Oct 28, 2026
Bohreromir
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs
Release note
Checklist
Author
Reviewer
Acceptance