Repository navigation
Bookmarks in DB - API - #413
Open
Bohreromir wants to merge 8 commits into
Open
Bohreromir wants to merge 8 commits into
Bohreromir wants to merge 8 commits into
Conversation
Cap name (40), environment (100), URL (2048) and product id (64) in the bookmark form schema, and set matching maxlength on the dialog inputs so the form cannot submit values the upcoming bookmarks API rejects.
Add a user_bookmarks table (migration 0004) and a /api/bookmarks REST API (GET/POST, PATCH/DELETE by id) scoped to the signed-in user. Requests without a user, e.g. with OIDC disabled, are answered with 401. Operations are counted in dashboard_bookmarks_total. The dashboard still uses localStorage; switching it to the API follows.
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
New bookmarks must name a known product; stored ones keep any non-empty id and show unknown ones as a custom link. Malformed bookmark ids are rejected with 400 like other id routes, and environments are trimmed.
Creating a bookmark beyond the limit is rejected with 409, so the list that every page loads stays small.
dervoeti
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
dervoeti
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs
Release note
Checklist
Author
Reviewer
Acceptance