Repository navigation
Fix 359 storage errors - #407
Merged
Merged
Conversation
Storage endpoints used 401 both for an expired session and for a request without a usable storage connection. The client mapped every 401 to "not connected", so an expired session showed connection errors, and every missing connection made the client re-check the session. Answer a missing or unknown connection with 409 and reason: 'not-connected' instead, so 401 only means the session expired. The storage client, upload and page loads recognise the reason; a 409 without it is still an edit conflict.
The details modals, the directory size calculation, archive toasts and the save fallback toast showed err.message as is: the server's English text, raw upstream errors, or "Request failed with status 502". Map the error code to translated messages instead. Details requests get specific messages for a missing connection, denied access and missing items, and a "failed to load" fallback for everything else. The unused storage_details_error_fetch_* keys serve as these fallbacks and no longer take a status.
…-359-storage-errors
lfrancke
approved these changes
Oct 28, 2026
lfrancke
left a comment
lfrancke
left a comment
Member
There was a problem hiding this comment.
It took me a while (from the title only) to understand what those 359 errors are supposed to be :)
Bohreromir
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Storage endpoints used 401 both for an expired session and for a request without a usable storage connection. The client mapped every 401 to "not connected", so an expired session showed connection errors, and every missing connection made the client re-check the session.
closes #359
Docs
Release note
Checklist
Author
Reviewer
Acceptance