Repository navigation
fix: circular imports for extensions - #1764
Merged
Merged
Conversation
This was referenced Jul 1, 2026
hrodmn
approved these changes
Jul 23, 2026
|
|
||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter("ignore", DeprecationWarning) | ||
| for entry_point in entry_points(group="pystac.extensions"): |
Collaborator
There was a problem hiding this comment.
the entry_points approach is elegant!
| from pystac.utils import HREF | ||
|
|
||
| import pystac.extensions.hooks | ||
| import pystac.extensions.classification |
Collaborator
There was a problem hiding this comment.
ah yeah, pystac.extensions.classification imports pystac 🔃
Member
Author
There was a problem hiding this comment.
Yeah I missed this one hard on the initial refactor
| dependencies = ["pystac-core"] | ||
| dependencies = [ | ||
| "pystac-core", | ||
| "pystac-ext-raster", |
Collaborator
There was a problem hiding this comment.
I like how the related extensions are explicitly listed as dependencies here
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We didn't get the extension refactor correct in #1650 (my fault). Rather than static imports, this PR converts things to an extension registry via an entry point group.
I'm not sure how bad the https://pypi.org/project/pystac/1.15.1/ release is — while the new sub-packages aren't correct, it's still fine to use the top level pystac package (which is all that existed before v1.15). I'm inclined to not yank v1.15.1, but happy to hear other opinions.