Skip to content

chore: actually set release-please manifest correctly - #1723

Merged
gadomski merged 1 commit into
mainfrom
fix-release-manifest
May 8, 2026
Merged

gadomski merged 1 commit into
mainfrom
fix-release-manifest

Conversation

@gadomski

@gadomski gadomski commented May 8, 2026

Copy link
Copy Markdown
Member

🤦🏼 I did it wrong in #1721

@gadomski gadomski self-assigned this May 8, 2026
@gadomski
gadomski requested a review from ciaransweet May 8, 2026 14:53

@ciaransweet ciaransweet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should every version still be an rc? (and should they be getting bumps?)

@gadomski

gadomski commented May 8, 2026

Copy link
Copy Markdown
Member Author

Should every version still be an rc? (and should they be getting bumps?)

None of the extension packages have ever been released, so they don't need bump.

For the extensions, I think an rc would be a good idea, but I'm not 100% sure ... thoughts?

@ciaransweet

Copy link
Copy Markdown
Collaborator

Should every version still be an rc? (and should they be getting bumps?)

None of the extension packages have ever been released, so they don't need bump.

For the extensions, I think an rc would be a good idea, but I'm not 100% sure ... thoughts?

I guess it's a question of 'how likely are they to be installed separately vs just bundle in with this package'

I think having them isn't an issue anyway.

@gadomski
gadomski added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit 81ff5a8 May 8, 2026
18 checks passed
@gadomski
gadomski deleted the fix-release-manifest branch May 8, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants