feat: scaffold CODEOWNERS and AWS OIDC example in cascade init#237
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cascade initalready scaffolds a starter manifest plus build/deploy callback stubs and self-checks them through the real generator, but issue #4's acceptance list also calls for a starter.github/CODEOWNERSand an AWS OIDC role example, and the verifying-starter property (init then generate leaves verify clean) was never proven in a test.Fix
internal/scaffold: every scaffold now also emits.github/CODEOWNERS(catch-all review rule with a placeholder team) and.github/aws-oidc-role.example.json(an IAM trust-policy example for GitHub Actions OIDC, matching the documentedconfigure-aws-credentialsrole-to-assume format, with placeholder account/org/repo). Both shapes (release-only and multi-env) get both files. Content is static and deterministic.internal/initcmd/verify_clean_test.go: runs the realinitinto a temp dir for the no-env and four-env shapes, generates the planned workflows the waygenerate-workflowdoes, then assertsverify.Runreturns nil (no drift, no orphans). This is the verifying-starter proof.initsection and README quick-start note the new files and the verifying-starter property.Verification
go build ./cmd/... ./internal/...: OKgo test ./...: green except the documented local-onlyTestNormalizeWorkflowPath_ActionlintCleanflake ininternal/generate(actionlint resolves reusable-workflow paths against the real repo root; untouched by this change, passes in CI).golangci-lint run ./...: 0 issues.Closes #4.