test: cover core rollback under the two-environment model#48
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
Cascade plan previewThis merge would:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the suite walked seed -> staging -> prod publish but never exercised a manual rollback under the two-environment model, leaving the core rollback path unproven on real GitHub for this repo.
Change: a new
rollback-checkjob (betweenpromote-staginganddispatch-inputs-check) lands a second staging version so the deploy-history ring carries a prior entry, dispatches the already-generatedcascade-rollback.yamlforstaging, waits via the establishedgh run list --created+gh run watch --exit-status --interval 60idiom, then asserts viayqon.github/manifest.yamlthat.ci.state.staging.versionmoved back to the prior entry and.ci.state.staging.ref == rollback/staging.Note on target: staging is the deployable env in this
[staging, prod]model. prod is the publish boundary and emits no deploy jobs, so its env state stays empty and it carries no deploy-history ring; a rollback of prod has no prior target to resolve. staging is therefore the env that exercises the core rollback path, matching the behavior the local harness proves.How it proves the gap: it dispatches the generated rollback workflow and reads back the rolled-back version and the divergence ref from trunk, proving the rollback re-deploy and finalize state write on real GitHub.
Verification: actionlint clean; yq parse clean; guardrail scans clean.