Conversation
Signed-off-by: Shaaf Syed <474256+sshaaf@users.noreply.github.com>
• Corrupt extension bytes — good panic-vs-Err check. • 10k-node determinism — useful smoke; not really an allocator stress test, but a solid parity lock. Signed-off-by: Shaaf Syed <474256+sshaaf@users.noreply.github.com>
…function, then dropped. Real hot-path waste. • Vec in serialize — heap alloc per node with props; stack sort for ≤8 is the right fix. • Read path BTree → HashMap — unnecessary; deserialize straight into LazyStringMap/HashMap. • NodeExtensionRef — correct zero-copy write shape (matches AGENTS.md clone hygiene). Signed-off-by: Shaaf Syed <474256+sshaaf@users.noreply.github.com>
sshaaf
marked this pull request as ready for review
September 22, 2026 14:16
…consider merge between pr-check and diff command Signed-off-by: Shaaf Syed <474256+sshaaf@users.noreply.github.com>
Signed-off-by: Shaaf Syed <474256+sshaaf@users.noreply.github.com>
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changednodes indiff_snapshotswhen node properties are unchanged ([BUG] diff_snapshots reports spurious Changed nodes: extension digest depends on HashMap iteration order #93):HashMapiteration madeextension_digest/content_digestnon-deterministic.LazyStringMapwith sorted keys; storeNodeExtensionproperties asBTreeMap; keep ingest onHashMap.Test plan
cargo test -p rgctl-graph --libcargo test -p rgctl-analysis --lib macro_call_fingerprint_matches_rebuilt_snapshotRelated: #93