Skip to content

fix(scripts): make fetch-profile-repos.sh executable - #91

Merged
sshaaf merged 1 commit into
sshaaf:mainfrom
nerdalytics:fix/fetch-profile-repos-exec-bit
Sep 21, 2026
Merged

sshaaf merged 1 commit into
sshaaf:mainfrom
nerdalytics:fix/fetch-profile-repos-exec-bit

Conversation

@nerdalytics

Copy link
Copy Markdown
Contributor

Description

./scripts/fetch-profile-repos.sh exits with permission denied. The file has been mode 100644 since d8cc106 added it on 2026-08-19, so the command in the docs has never worked.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

scripts/fetch-profile-repos.sh. It is the only shell script in scripts/ at 100644, and the other five are 100755. It has a #!/usr/bin/env bash shebang, and 27 call sites invoke it as ./scripts/fetch-profile-repos.sh.

The 27 call sites:

  • tests/cold_profile_gates.rs (12, of which 8 are skip messages telling the reader to run it)
  • example/README.md (3)
  • docs/markdown-context.md (3)
  • AGENTS.md (2)
  • docs/internal/profile.md (2)
  • docs/guides/markdown-context-graph.md (2)
  • docs/agent-recipes.md, docs/internal/PR-check.md, rgctl-tests/README.md (1 each)

Testing

On main, ./scripts/fetch-profile-repos.sh gives permission denied and test -x fails. On this branch test -x passes and bash -n reports no syntax error. I did not run the fetch itself, because it clones 14 repositories including torvalds/linux and llvm/llvm-project.

  • Unit tests added/updated
  • Integration tests added/updated
  • Tested with cargo test
  • Manual testing performed

Test environment:

  • OS: macOS 26.6.2 (Darwin 25.6.0)

Checklist

  • I have performed a self-review of my code
  • Documentation updated (if applicable). The docs already give the intended invocation. This makes that invocation run.
  • CONTRIBUTING.md guidelines followed
  • All commits are signed and include DCO sign-off

Breaking Changes

None. No workflow under .github/workflows/ runs this script, and the file content is unchanged.

Additional Notes

The alternative is to rewrite the 27 call sites as bash ./scripts/fetch-profile-repos.sh. One mode bit is the smaller change, and it matches the other five scripts.

The script has a bash shebang and 27 call sites across the docs and the
cold-profile tests invoke it as ./scripts/fetch-profile-repos.sh, but git has
carried it at mode 100644 since it was added in d8cc106. Every other script in
scripts/ is 100755, so the documented command exits with permission denied.

Signed-off-by: nerdalytics <97166791+nerdalytics@users.noreply.github.com>
@sshaaf
sshaaf merged commit 3de8cd5 into sshaaf:main Sep 21, 2026
@nerdalytics
nerdalytics deleted the fix/fetch-profile-repos-exec-bit branch September 21, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants