feat(install): add Antigravity skill installation support (#87) - #88
Conversation
sshaaf
left a comment
There was a problem hiding this comment.
Thanks for wiring Antigravity into the default --tools set and docs — that part looks right (DEFAULT_INSTALL_AGENTS, --tools antigravity, .agent/skills/…).
Please do not extend the deprecated --host / SkillHost surface. --host is already documented as deprecated in favor of --tools (registry adapter ids). New adapters should only go through --tools / DEFAULT_INSTALL_AGENTS.
Inline comments call out the --host-related hunks to drop or rewrite. Also please update the stale lib unit test default_install_agents_are_v1_quad (still asserts the old four ids while DEFAULT_INSTALL_AGENTS now includes antigravity) — that fails today with cargo test --lib default_install_agents_are_v1_quad.
| /// `<repo>/.cursor/skills/rgctl/` | ||
| Cursor, | ||
| /// `<repo>/.agent/skills/rgctl/` | ||
| Antigravity, |
There was a problem hiding this comment.
--host / SkillHost is deprecated (src/cli/mod.rs: "Deprecated: use --tools"). Please do not add Antigravity here. Antigravity should only be a registry/--tools id (already in agent-pack/agents/registry.toml). Leave SkillHost frozen until removal.
| super::args::SkillHost::Claude => vec!["claude".to_string()], | ||
| super::args::SkillHost::Codex => vec!["codex".to_string()], | ||
| super::args::SkillHost::Cursor => vec!["cursor".to_string()], | ||
| super::args::SkillHost::Antigravity => vec!["antigravity".to_string()], |
There was a problem hiding this comment.
Same concern: this arm only exists to serve deprecated --host antigravity. Drop it (and the SkillHost::Antigravity variant). Default/--tools coverage is already handled by adding "antigravity" to DEFAULT_INSTALL_AGENTS above — keep that.
| "install", | ||
| "--skill", | ||
| "--host", | ||
| "antigravity", |
There was a problem hiding this comment.
Please rewrite this test to use the supported flag:
install --skill --tools antigravity
Do not add regression coverage that exercises --host. We do not want to grow or validate the deprecated path for new adapters.
| Claude, | ||
| Codex, | ||
| Cursor, | ||
| Antigravity, |
There was a problem hiding this comment.
Note: this is not CLI --host, but it is another legacy host surface (InstallWriteHost — "Legacy host ids (schema v1); prefer agent string in v2").
Prefer leaving this enum unchanged for new adapters (JSON consumers should use writes[].agent == "antigravity"). If we must keep schema-v1 host populated for the default set, call that out explicitly; otherwise avoid expanding this deprecated field for Antigravity.
| "claude" => Some(InstallWriteHost::Claude), | ||
| "codex" | "agents" => Some(InstallWriteHost::Codex), | ||
| "cursor" => Some(InstallWriteHost::Cursor), | ||
| "antigravity" => Some(InstallWriteHost::Antigravity), |
There was a problem hiding this comment.
Paired with the InstallWriteHost::Antigravity variant — same ask: avoid growing schema-v1 host mapping for a new adapter unless there is a concrete consumer still requiring it. Prefer agent only.
| fn test_install_json_schema_hosts_serialization() { | ||
| for (agent, expected) in [ | ||
| ("claude", "claude"), | ||
| ("antigravity", "antigravity"), |
There was a problem hiding this comment.
If we drop InstallWriteHost::Antigravity / host_compat("antigravity"), remove this case (or assert host is null/None and agent is "antigravity").
Commit signing & PR checklistA couple of process nits when you have a moment — nothing blocking the Antigravity/ Commit signing. The commit message already includes a PR description checklist. The description still has the blank template sections ( Happy to re-review once those and the |
449d951 to
2bdc3c4
Compare
Add Antigravity skill installation support to `rgctl install --skill`. - Include `antigravity` in `DEFAULT_INSTALL_AGENTS` alongside cursor, claude, codex, and agents - Support installing Antigravity adapter skills via `--tools antigravity` - Update unit tests in `src/cli/agent_pack.rs` to reflect the 5 default install agents - Add regression coverage in `tests/install_skill.rs` and `tests/cli_output/install.rs` - Update CLI, JSON API, installation, agent guides, and website documentation Fixes sshaaf#87 Signed-off-by: tanvir70 <tanvir.anjum@bracits.com>
2bdc3c4 to
8a8b558
Compare
|
Addressed all comments:
|
Add Antigravity skill installation support to
rgctl install --skill.antigravityinDEFAULT_INSTALL_AGENTSalongside cursor, claude, codex, and agents--tools antigravity.agent/skills/adhering to Antigravity's workspace skill conventionssrc/cli/agent_pack.rsto reflect the 5 default install agentstests/install_skill.rsandtests/cli_output/install.rsDescription
Adds Google Antigravity skill installation support to
rgctl install --skill. Antigravity discovers workspace skills under.agent/skills/. This PR wires the Antigravity adapter intoDEFAULT_INSTALL_AGENTSand--tools antigravitywhile leaving the deprecated--host/SkillHostlegacy surface frozen.Fixes #87
Type of Change
Changes Made
"antigravity"toDEFAULT_INSTALL_AGENTSinsrc/cli/agent_pack.rs.--tools antigravityto install skills directly to.agent/skills/.default_install_agents_are_v1_quadto assert all 5 default agents.tests/install_skill.rsverifying--tools antigravityand default install paths.tests/cli_output/install.rsensuringagent: "antigravity"is emitted without legacy schema v1host.docs/guides/agent-commands.md,docs/guides/agent-skill.md), and website install page.Testing
cargo testTest commands run:
cargo test --lib default_install_agents_are_v1_quadcargo test --lib agent_packcargo test --test install_skillcargo test --test cli_output test_install_json_schemacargo test --test subprocess_golden_pathcargo build --release --bin rgctl./target/release/rgctl -r "$TMPDIR" -f json install --skill --tools antigravityTest environment:
Checklist
cargo fmt)cargo test)Signed-off-by:)Performance Impact
Breaking Changes
None. Deprecated
--hostand schema v1hostfields remain frozen and unchanged.