fix: explicit defaults for all ReactNativeFeatureFlags (#24)#25
Merged
Conversation
The Proxy-only mock left every flag except isLayoutAnimationEnabled absent as own-properties, so named imports / Object.keys / spreads could miss enableNativeCSSParsing and other flags. Enumerate every flag from RN 0.83 with its real default and keep the Proxy fallback for future flags. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
srsholmes
added a commit
that referenced
this pull request
May 1, 2026
PR #25 was merged without a changeset, so the fix would not appear in any release. Adding a retroactive changeset so it ships in the same patch release as the cache race-condition fix in this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24.
Summary
isLayoutAnimationEnabledabsent as an own-property, so named imports,Object.keys, and object spreads could missenableNativeCSSParsingand the other ~100 flags.preparedTextCacheSize/viewCullingOutsetRatio/virtualViewHysteresisRatio/virtualViewPrerenderRatio, the stringvirtualViewActivityBehavior, andoverride).() => falsewithout asetup.tsedit.Test plan
pnpm test:run— 809/809 passing across 63 filespnpm typecheck— cleanpnpm lint— no new findings (5 pre-existing warnings inapps/example-app/__parity-tests__/test-utils.ts)pnpm build— succeedsFeatureFlags.spec.tsxextended to cover non-boolean defaults,Object.keys/ spread enumeration, and the originalenableNativeCSSParsingregression.🤖 Generated with Claude Code