review comments for the docs I've read so far - #66
Draft
meiersi-da wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important disclaimer
This review is not an endorsement of this work. It is a purely technical review aimed at learning how TSv2 is used and providing input as an experienced Daml developer.
Content
@srikanth-bitdynamics : I've found some time today to start the review. What I've read so far looks promising, but I will want to read more of the solution to create a qualified review. However, my time budget is still very constraints, which is why I'm sharing these first comments with you, so you can start processing them.
Just a word of warning: it might sadly take me another 1.5 weeks until I can continue on this work, as the next week is full of workshops. I'm sorry for that.