Repository navigation
Conversation
OnClientDisconnect also fires for clients that drop before entering the game. VIP Core natives throw "Client X is not connected" for those, so bail out early unless the client is in game. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V2Q4N9D2yxJ52SzU4SsRns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
Summary
OnClientDisconnectnow returns early when!IsClientInGame(client). VIP Core natives throwClient X is not connectedfor clients that disconnect before entering the game.2.1.1.Note
This change does not touch a separate issue in the same condition.
VIP_GetClientVIPGroup(client, testVipGroup, ...)writes the client's group intotestVipGroupand returnstrueon success. It does not compare the group with the test group, so the removal of test VIP on disconnect (and in the equivalent loop around line 172) likely never runs. It's left as is here because fixing it would change behavior.🤖 Generated with Claude Code
https://claude.ai/code/session_01V2Q4N9D2yxJ52SzU4SsRns
Generated by Claude Code