Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
FixClientUI()(called on any non-infection death of a player in thirdperson/mirror, e.g.sm_specwith forced suicide,kill, fall damage) moved the player to spectator and then always to T when ZombieReloaded is loaded.Before the mother zombie spawns every player is CT, so this created the first spawnable T. CS:S
CCSGameRules::NeededPlayersCheckthen sees both teams populated after one was empty and callsTerminateRound(3.0, Game_Commencing), restarting the round. Neither ZR nor TeamManager (outside warmup) block that reason.Fix
FixClientUI()puts the player back in their original team instead of forcing T (ZR already moves T spawns to CT and its respawn timer accepts both teams). No-op if the player is not on T/CT.sm_tp/sm_mirroradded in feat: bump to 1.3.1 #9 as a workaround, and its now-unused state (g_bZombieSpawned,g_bTeamManager,round_starthook,ZR_OnClientInfected).Verification
Compiled with spcomp 1.13.0.7427, no errors/warnings.
Closes #10