Repository navigation
Fix missing OpenFile() check and unbounded TextColors write - #25
Merged
Merged
Conversation
RefreshConfig() never checked whether OpenFile() succeeded before reading from the handle, and never bounded CountColors against the fixed-size TextColors array (MAXTEXTCOLORS = 100), so a config with more than 100 color entries would trip a runtime array-bounds error mid-reload. Fixes #24 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Reload failures must be propagated and reported instead of being reported as successful.
Review effort: Lite
Findings: None
What changed in this PR
Fixes configuration loading by validating OpenFile() and bounding color entries to MAXTEXTCOLORS.
Changes:
- Handles missing or unreadable configuration files.
- Prevents out-of-bounds writes.
- Logs ignored excess entries.
| File | Summary |
|---|---|
addons/sourcemod/scripting/SMTextReplace.sp |
Adds file-open validation and bounds protection during configuration loading. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RefreshConfig()never checkedOpenFile()'s result before reading from it.CountColorswas never bounded againstMAXTEXTCOLORS, so a config with more than 100 color entries would write past the end ofTextColors.Fixes #24
Test plan
🤖 Generated with Claude Code