perf(memory): replace fixed-size sound arrays with per-set StringMaps

[Rushaway]

Closes #45

@cmer81 could you review this one?

Memory

Sounds now live in one StringMap per set ("<type>:<num>" -> path + config), so only the configured ones use memory.

	Before	After
Data size (spcomp 1.12)	202,312,232 bytes	27,680 bytes
.smx	1.28 MB	16 KB

Other changes

• LoadSet() loads every section with one loop over g_sSoundSections[] instead of 10 copy-pasted blocks.
• On each kill, the sound is picked once per set instead of once per client (which copied six 256-byte strings per client), then sent with one EmitSound() call per set.
• sm_quakesounds_volume now applies without a map change.
• Version 4.3.0. Config files and the cookie format are unchanged.

Behavior changes (bug fixes)

1. Headshots: the streak sound (1, 3 hattrick, 5 headhunter) now comes first, else the generic 0. The old generic branch was keyed on the kill streak (L928): you could get the hattrick sound with the "Headshot" text, or nothing at all on a 2nd headshot.
2. Teamkill used the selfkill config (L832).
3. Sound and text preferences are independent. Disabling sounds also hid the text (L922), while the selfkill sound played anyway (L805).
4. Victim streak was not reset when sm_quakesounds_selfkill or sm_quakesounds_teamkill is 0, because of an early return (L800-L801, L824-L825).
5. Past the last killsound, the random sound comes from the set's configured kill sounds instead of a hard-coded list (L1116). It is the same list for male and female. It uses that sound's own config instead of forcing "everyone".
6. "config" "0" sounds are no longer downloaded nor precached, as the README says.
7. Late load: no more join sound and announce sent to everyone. The saved sound set is kept: cookies were read before the sets were loaded, so everyone fell back to the first set.
8. Errors: streaks of 999+ kills indexed out of bounds (L928). A missing translation phrase threw and stopped the client loop; it is now logged instead.

Testing

• Builds with spcomp 1.12.0.7255, no warnings.
• Not tested in game yet. To check: first blood, 1 to 5 headshots in a row, knife, grenade, combo, teamkill, selfkill, and sm plugins reload QuakeSounds with players connected.

[Copilot]

Copilot review overview

🔵 Needs a closer look

Core event, configuration, and playback paths were extensively rewritten without in-game validation.

Review effort: Balanced
Findings: None

What changed in this PR

Replaces oversized fixed sound arrays with per-set dynamic maps, substantially reducing plugin memory use while consolidating sound handling and fixing event/preference behavior.

Changes:

• Stores configured sounds in StringMap and ArrayList structures.
• Centralizes sound selection, targeting, loading, and playback.
• Updates contributor guidance for the new architecture.

File	Description
addons/​sourcemod/​scripting/​QuakeSounds.sp	Refactors sound storage and event handling, plus preference and behavior fixes.
.github/​copilot-instructions.md	Documents the dynamic sound-storage design and extension process.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[cmer81]

Code review

No blocking issues found. Checked for bugs and CLAUDE.md compliance; the head compiles cleanly on SourceMod 1.13.0.7427 with no new diagnostics against master. A few non-blocking notes:

1. The SoundType enum comment and the "Adding New Sound Events" guide say numbered sounds just need to stay before Sound_FirstBlood, but LoadSet() hardcodes type <= Sound_Combo. A new numbered type added after Sound_Combo would be parsed as a non-numbered section. A Sound_LastNumbered marker, or a note in the guide, would avoid that.

sm-plugin-QuakeSounds/addons/sourcemod/scripting/QuakeSounds.sp

Lines 709 to 712 in 55f7634

	}
	bool numbered = type <= Sound_Combo;
	if (kv.GotoFirstSubKey() != numbered)

2. A killsound section with "config" "0" is skipped at load and never pushed to g_aSetKillNums. If it was the highest kill number, the "past the last sound" threshold drops and the random replay starts earlier. A non-numeric section name also becomes kill number 0 via StringToInt. The shipped configs are not affected.

sm-plugin-QuakeSounds/addons/sourcemod/scripting/QuakeSounds.sp

Lines 728 to 734 in 55f7634

	if (num >= 0 && LoadSound(kv, set, type, num, setFile) && type == Sound_Kill)
	g_aSetKillNums[set].Push(num);
	} while (kv.GotoNextKey());
	}
	g_aSetKillNums[set].Sort(Sort_Ascending, Sort_Integer);
	delete kv;

3. LoadQuakeSetConfig() re-reads the sets on every map start, but g_iSoundPreset[client] is only re-clamped on connect and cookie read. If the set list shrinks between maps, a connected player keeps an out-of-range preset and hears nothing until they cycle the sound pack in the menu. This was already the case before the PR, and only matters if sets.cfg changes.

sm-plugin-QuakeSounds/addons/sourcemod/scripting/QuakeSounds.sp

Lines 130 to 133 in 55f7634

	public void OnMapStart()
	{
	LoadQuakeSetConfig();
	if (g_evGameEngine == Engine_HL2DM)

4. Behavior changes that the PR description does not list: sounds with config 0 are no longer precached or added to the downloads table, and the random replay past the last streak now honors that entry's own target bits instead of always playing to everyone.