Skip to content

chore(ci): replace SourceKnight with setup-sp - #31

Merged
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight
Aug 17, 2026
Merged

Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight

Conversation

@Rushaway

Copy link
Copy Markdown
Member

Summary

Replaces the SourceKnight-based build (maxime1907/action-sourceknight) with a native GitHub Actions workflow using rumblefrog/setup-sp, matching the pattern already rolled out across the srcdslab org (e.g. sm-plugin-AdminRoom).

Plugin targets

Target Source file
FixSprayExploit addons/sourcemod/scripting/FixSprayExploit.sp

Dependencies (from sourceknight.yaml)

Name Repo URL Unpack source → dest
sourcebans-pp https://github.com/srcdslab/sourcebans-pp /game/addons → /addons

(The sourcemod dependency was a type: tar runtime drop, not a git include dependency, and is now provided by rumblefrog/setup-sp@v1.3.1 pinned to SourceMod 1.12.x instead.)

Changes

  • Added .github/workflows/ci.yml with build / tag / release jobs (checkout → setup-sp → clone+copy dependency includes → spcomp → package → upload artifact; tag latest on master/main; release on tag or master/main pushes).
  • Removed sourceknight.yaml.
  • Updated .github/copilot-instructions.md and .gitignore to drop SourceKnight references.
  • Packaging step copies the compiled .smx into addons/sourcemod/plugins/. No configs/, translations/, cfg/, materials/, gamedata/, etc. directories exist in this repo, so nothing else is packaged.

Not locally validated

Per the migration process, no dependency repos were cloned, no spcomp was run, and nothing was compiled locally. This PR relies on the CI run itself (the build job) to confirm the plugin compiles successfully against the declared dependency includes.

Manual verification needed

  • Confirm the sourcebans-pp repository still exposes its includes at game/addons/sourcemod/scripting/include/ (path taken as-is from sourceknight.yaml, not independently verified).
  • Confirm no additional packaging paths (configs/translations/etc.) are expected beyond the compiled .smx.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 17, 2026 08:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rushaway
Rushaway merged commit 3b4b33f into master Aug 17, 2026
6 checks passed
@Rushaway
Rushaway deleted the chore/drop-sourceknight branch August 17, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants