Repository navigation
chore(ci): replace SourceKnight with setup-sp - #31
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight) with a native GitHub Actions workflow usingrumblefrog/setup-sp, matching the pattern already rolled out across the srcdslab org (e.g.sm-plugin-AdminRoom).Plugin targets
addons/sourcemod/scripting/FixSprayExploit.spDependencies (from
sourceknight.yaml)/game/addons→/addons(The
sourcemoddependency was atype: tarruntime drop, not a git include dependency, and is now provided byrumblefrog/setup-sp@v1.3.1pinned to SourceMod1.12.xinstead.)Changes
.github/workflows/ci.ymlwithbuild/tag/releasejobs (checkout → setup-sp → clone+copy dependency includes → spcomp → package → upload artifact; taglateston master/main; release on tag or master/main pushes).sourceknight.yaml..github/copilot-instructions.mdand.gitignoreto drop SourceKnight references..smxintoaddons/sourcemod/plugins/. Noconfigs/,translations/,cfg/,materials/,gamedata/, etc. directories exist in this repo, so nothing else is packaged.Not locally validated
Per the migration process, no dependency repos were cloned, no
spcompwas run, and nothing was compiled locally. This PR relies on the CI run itself (thebuildjob) to confirm the plugin compiles successfully against the declared dependency includes.Manual verification needed
sourcebans-pprepository still exposes its includes atgame/addons/sourcemod/scripting/include/(path taken as-is fromsourceknight.yaml, not independently verified)..smx.