Fix(logic): comparison napalm lag filter#22
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a SourcePawn-specific logic bug in the FixNapalmLag SourceMod plugin that incorrectly treated a chained comparison as a valid client-range check, causing over-broad suppression of burn damage.
Changes:
- Corrected the client-index range check from a chained comparison to an explicit logical conjunction (
>= 1 && <= MaxClients). - Bumped the plugin version from
1.0.5to1.0.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request description:
This PR fixes a logic bug in the napalm lag filter where a chained comparison was used to check if iEntIgnore is a valid client index. In SourcePawn, chained comparisons do not behave as mathematical inequalities, which caused the condition to always evaluate as true.
Replaces the chained comparison with a proper logical conjunction:
if (iEntIgnore >= 1 && iEntIgnore <= MaxClients)Ensures only client-originated napalm damage is blocked
Prevents unintended suppression of other burn damage sources
This resolves incorrect damage filtering and restores intended plugin behavior.
Full details: #21