Repository navigation
feat: use newest SourceMod decls and methodmaps - #29
Merged
Merged
Conversation
- Replace LoadGameConfigFile/GameConfGetAddress with the GameData methodmap - Replace DHookCreateDetour/DHookAddParam/DHookEnableDetour with DynamicDetour - Use DHookParam.Get instead of DHookGetParam - Drop the FloatMod/operator% shim (native since SourceMod 1.12) - Bump version to 1.0.4 and update Copilot instructions Closes #28 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the plugin to use the newest SourceMod API (closes #28).
LoadGameConfigFile/GameConfGetAddress→GameDatamethodmap (new GameData(...),.GetAddress(...))DHookCreateDetour/DHookAddParam/DHookEnableDetour→DynamicDetourmethodmap (new DynamicDetour(...),.AddParam(...),.Enable(Hook_Pre, ...))DHookGetParam(hParams, 1)→DHookParam.Get(1)(callback now takes aDHookParam)FloatMod/operator%compatibility shim, since float%is native in SourceMod 1.12 (the version CI builds against)1.0.4.github/copilot-instructions.mdexamples to reflect the new APINo behavior change intended.
Testing
🤖 Generated with Claude Code