Repository navigation
chore(ci): replace SourceKnight with setup-sp - #23
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the SourceKnight-based build (
maxime1907/action-sourceknight) with a native GitHub Actions workflow usingrumblefrog/setup-sp, matching the org-standard CI layout already validated insrcdslab/sm-plugin-AdminRoom.Plugin targets
addons/sourcemod/scripting/FixFuncRotating.spDependencies
sourceknight.yamldeclared only thesourcemodruntime (type: tar), notype: gitdependencies.FixFuncRotating.sponly includes standard<sourcemod>,<sdktools>,<dhooks>.SourceMod compiler version is pinned to
1.12.xinrumblefrog/setup-sp, per the org migration standard (independent of the version declared in the oldsourceknight.yaml).Packaging
The old workflow's
Create packagestep copied the SourceKnight-built package output plusaddons/sourcemod/gamedataintocommon/addons/sourcemod/. The new workflow copies:.smxintoaddons/sourcemod/plugins/addons/sourcemod/gamedata/intoaddons/sourcemod/gamedata/No
configs/,translations/, or other extra directories exist in this repo's tree.Not locally validated
No dependency clone, no
spcompdownload, and no local compilation were performed as part of this migration (lightweight pass, per instructions). This PR relies on the CI run itself to confirm the plugin compiles and packages correctly.Manual verification needed
None identified — packaging paths were verified to exist in the repo tree (gamedata only, no configs/translations/other asset dirs).
Also removed
sourceknight.yaml, cleaned up.gitignore, and updated.github/copilot-instructions.mdto no longer reference SourceKnight.Co-Authored-By: Claude Opus 5 noreply@anthropic.com