Skip to content

chore(ci): replace SourceKnight with setup-sp - #23

Merged
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight
Aug 17, 2026
Merged

Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight

Conversation

@Rushaway

Copy link
Copy Markdown
Member

Summary

Replaces the SourceKnight-based build (maxime1907/action-sourceknight) with a native GitHub Actions workflow using rumblefrog/setup-sp, matching the org-standard CI layout already validated in srcdslab/sm-plugin-AdminRoom.

Plugin targets

Target Source file
FixFuncRotating addons/sourcemod/scripting/FixFuncRotating.sp

Dependencies

Name Repo URL Unpack path used
(none) — sourceknight.yaml declared only the sourcemod runtime (type: tar), no type: git dependencies. FixFuncRotating.sp only includes standard <sourcemod>, <sdktools>, <dhooks>.

SourceMod compiler version is pinned to 1.12.x in rumblefrog/setup-sp, per the org migration standard (independent of the version declared in the old sourceknight.yaml).

Packaging

The old workflow's Create package step copied the SourceKnight-built package output plus addons/sourcemod/gamedata into common/addons/sourcemod/. The new workflow copies:

  • the compiled .smx into addons/sourcemod/plugins/
  • addons/sourcemod/gamedata/ into addons/sourcemod/gamedata/

No configs/, translations/, or other extra directories exist in this repo's tree.

Not locally validated

No dependency clone, no spcomp download, and no local compilation were performed as part of this migration (lightweight pass, per instructions). This PR relies on the CI run itself to confirm the plugin compiles and packages correctly.

Manual verification needed

None identified — packaging paths were verified to exist in the repo tree (gamedata only, no configs/translations/other asset dirs).

Also removed sourceknight.yaml, cleaned up .gitignore, and updated .github/copilot-instructions.md to no longer reference SourceKnight.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 17, 2026 08:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rushaway
Rushaway merged commit 68eb3a5 into master Aug 17, 2026
6 checks passed
@Rushaway
Rushaway deleted the chore/drop-sourceknight branch August 17, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants