Skip to content

fix(apps): persist auto-select knowledge base checkbox - #72

Merged
squarezw merged 1 commit into
mainfrom
fix/persist-auto-select-datasets
Sep 18, 2026
Merged

squarezw merged 1 commit into
mainfrom
fix/persist-auto-select-datasets

Conversation

@squarezw

Copy link
Copy Markdown
Owner

Summary

  • Persist the “自动选择知识库” checkbox in settings.auto_select_datasets instead of inferring it from empty dataset_ids.
  • Restore the checkbox from that flag on edit, so unchecking it without binding datasets still survives a reopen.
  • Pair with ragent-service fix/honor-app-auto-select-datasets so chat actually stops auto-selecting when the flag is off.

Test plan

  • Edit an app, uncheck “自动选择知识库”, save without picking datasets, reopen — checkbox stays off and the dataset list is shown
  • Check it again, save, reopen — checkbox is on
  • Bind specific datasets with the checkbox off, save, reopen — selections and unchecked state remain
  • Existing apps that never saved the flag still treat empty dataset_ids as auto-select

Made with Cursor

Unchecking the option was inferred from empty dataset_ids, so saving
without bound datasets looked like auto-select again on reopen.
Store the flag in settings.auto_select_datasets and restore from it.

Co-authored-by: Cursor <cursoragent@cursor.com>
@squarezw
squarezw merged commit 025ef1a into main Sep 18, 2026
1 check passed
@squarezw
squarezw deleted the fix/persist-auto-select-datasets branch September 18, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant