feat(workflow): forward designated base-content lifecycle - #19
Draft
robmaceachern wants to merge 1 commit into
Draft
robmaceachern wants to merge 1 commit into
robmaceachern wants to merge 1 commit into
Conversation
Opt the shared modal and toast wrapper into Workflow screen-content preparation and retirement. Preserve wrapper identity while preparing replacement base controllers before containment or view loading; overlays remain separate. Pin the MRKT-142 Workflow draft revision and cover retained-wrapper replacement in hosted tests. Validation: full Modals and WorkflowModals hosted test suites passed on iOS 26.5; SwiftFormat source lint passed with generated Derived sources excluded. --- *This response was drafted with AI assistance.*
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward content-level integrations to the designated base controller of Workflow modal/toast wrappers. A navigation container can prepare that base's hosting content without changing application screen conformances or treating an overlay as the underlying screen.
This is the swift-modals portion of MRKT-142, used by Market #12772. It is stacked on the independently landable SwiftFormat prerequisite #18. Keep this PR draft until Rob manually examines it and explicitly approves conversion; no automatic readiness conversion or merge.
How it works
AnyModalToastContainerViewControlleradopts Workflow'sScreenContentProvidingcapability and owns one stableScreenContentLifecycleinitialized with its base controller.screenContent.replace(with:)throughprepareReplacement, before the update helper adds containment or loads the replacement's view. Existing integrations retire before the new base is prepared.4ab11c35339c842b20413478c5bcd8d1c8996f75. Other resolved package versions remain unchanged. Before release, land the approved Workflow API and replace this development pin with an appropriate released dependency version.Validation
mise exec -- tuist install --path Samplesandmise exec -- tuist generate --path Samples --no-openpass using the published Workflow revision, with no local package override.UnitTestsscheme (Modals-TestsandWorkflowModals-Tests) passes 66 tests, zero failures. The new parameterized regression verifies unchanged-base reuse and replacement preparation for both loaded and unloaded retained wrappers.mise exec -- swiftformat --lint . --exclude Derived --cache ignore: 0/141 files require formatting, 7 skipped.Derivedis generated Tuist output and is not part of the source diff.git diff --checkand normal commit hooks pass.Risk
The additive capability opts presentation wrappers into a public upstream lifecycle contract. Correctness depends on preparing only the designated base and announcing replacement before view loading. Hosted regression tests cover this timing without changing overlay presentation behavior.
Checklist
This response was drafted with AI assistance.