Fix stdoutEncode mangling non-string values used by REST API (#6054)#6056
Merged
stamparm merged 1 commit intosqlmapproject:masterfrom May 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6054.
What broke
In commit 09fadc4 ("Minor improvement of stdoutEncode", 2025-12-31), the non-string branch of
stdoutEncodechanged from passing values through unchanged to coercing them withstr():This breaks the REST API path.
lib/utils/api.pyoverridessys.stdout.writeto calljsonize(value), which expects the original Python value (e.g. adict). The existing call chain inlib/controller/controller.py:181is:flowing through
Dumper.string()→_write()→dataToStdout()→sys.stdout.write(stdoutEncode(...)).After the regression, the API now returns Python
repr()strings instead of structured JSON forvaluefields:Any client parsing the documented response shape breaks.
The fix
Restore the pre-1.10 behavior of returning non-string, non-bytes values unchanged. This matches the
else: retVal = valuebranch the previous implementation had.The encode/decode round-trip below is meaningful only for strings and bytes — applying it to dicts/lists/etc. has never been correct.
Verification
Added a doctest covering the dict case so this can't silently regress again.
python3 -m doctest lib/core/convert.py— all 38 tests pass.