Fixup #25 Migrate to GitHub Actions and source-based versioning#26
Merged
Annotations
10 warnings and 2 notices
|
build:
src/Dax.Formatter/Security/SecurityHelpers.cs#L22
The behavior of 'byte.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'string.ToHashSHA256()' with a call to 'byte.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
build:
src/Dax.Formatter/DaxFormatterClient.cs#L60
In externally visible method 'Task<IReadOnlyList<DaxFormatterResponse>> DaxFormatterClient.FormatAsync(DaxFormatterMultipleRequest request, CancellationToken cancellationToken = default(CancellationToken))', validate parameter 'request' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
build:
src/Dax.Formatter/DaxFormatterClient.cs#L54
In externally visible method 'Task<DaxFormatterResponse?> DaxFormatterClient.FormatAsync(DaxFormatterSingleRequest request, CancellationToken cancellationToken = default(CancellationToken))', validate parameter 'request' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)
|
|
build:
src/Dax.Formatter/Client/Http/DaxFormatterHttpClient.cs#L30
Call System.IDisposable.Dispose on object created by 'new DaxFormatterHttpClientMessageHandler()' before all references to it are out of scope (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
|
build:
src/Dax.Formatter/Models/DaxFormatterSeparatorStyle.cs#L5
Remove the underscores from member name Dax.Formatter.Models.DaxFormatterSeparatorStyle.US_UK (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
|
|
build:
src/Dax.Formatter/Models/DaxFormatterResponse.cs#L9
Change 'List<DaxFormatterError>' in 'DaxFormatterResponse.Errors' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
build:
src/Dax.Formatter/Models/DaxFormatterResponse.cs#L9
Change 'Errors' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
build:
src/Dax.Formatter/Models/DaxFormatterRequest.cs#L9
Abstract type 'DaxFormatterRequest' should not have public constructors (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1012)
|
|
build:
src/Dax.Formatter/Models/DaxFormatterMultipleRequest.cs#L18
Change 'List<string>' in 'DaxFormatterMultipleRequest.Dax' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
build:
src/Dax.Formatter/Models/DaxFormatterMultipleRequest.cs#L18
Change 'Dax' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
|
|
|
background
wait
wait-all
cancel
parallel
Loading