Fix session cookie writes for string responses#3763
Open
Sanjay44NS wants to merge 2 commits into
Open
Conversation
Commit the session once an explicit Content-Length of 0 is followed by a body write so String responses still write the session cookie, including empty-body cases. Add regressions for the wrapper and filter paths that previously missed the early commit. Signed-off-by: sanjay44ns <nunagondasanjay44@gmail.com>
Add plain String endpoints to the JDBC and Redis Boot samples and verify with MockMvc that the response sets the Spring Session cookie without falling back to JSESSIONID. Signed-off-by: sanjay44ns <nunagondasanjay44@gmail.com>
Sanjay44NS
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnCommittedResponseWrapperso Spring Session commits once an explicitly zero content-length response performs a body writeStringresponse writes theSESSIONcookieFixes #3755
Notes
spring-session-coreTesting
.\gradlew.bat :spring-session-core:test --tests "org.springframework.session.web.http.OnCommittedResponseWrapperTests" --tests "org.springframework.session.web.http.SessionRepositoryFilterTests".\gradlew.bat :spring-session-core:build.\gradlew.bat :spring-session-sample-boot-jdbc:integrationTest --tests "sample.BootTests.stringResponseSetsSessionCookie".\gradlew.bat :spring-session-sample-boot-redis:integrationTest --tests "sample.BootTests.stringResponseSetsSessionCookie"