Document extracting authentication from custom metadata - #422
Open
Adrastopoulos wants to merge 1 commit into
Open
Document extracting authentication from custom metadata#422Adrastopoulos wants to merge 1 commit into
Adrastopoulos wants to merge 1 commit into
Conversation
GrpcSecurity accepts arbitrary GrpcAuthenticationExtractor instances, but the reference docs only covered the built-in Authorization header mechanisms, so credentials carried in other metadata entries had no documented path. The composition rules were also untested: extractors are sorted by @order and the first non-null Authentication wins. Document authenticationExtractor() with a worked example and add tests covering extractor ordering and first-non-null resolution. Fixes spring-projectsgh-419 Signed-off-by: Gabriel Hall <gabriel.hall@cox.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents
authenticationExtractor()with a worked example reading a non-Authorizationmetadata key, for credentials the built-in extractors don't cover.Adds tests for the two composition behaviours that were previously uncovered:
@Ordercontrols extractor precedence, and the first non-nullAuthenticationwins. Both are driven through the interceptorGrpcSecuritybuilds.Fixes gh-419