Remove streamToolCallResponses from advisor builders#6391
Closed
tzolov wants to merge 1 commit into
Closed
Conversation
tzolov
force-pushed
the
remove-stream-tool-call-responses
branch
from
4002040 to
cede45c
Compare
When streamToolCallResponses=true, tool-call request chunks were streamed downstream without the paired ToolResponseMessage, corrupting any downstream memory advisor's conversation history. The flaw cannot be fixed cleanly, so the option is removed from ToolCallingAdvisor, ToolCallAdvisor, and ToolSearchToolCallingAdvisor builders along with the corresponding auto-configuration properties. Two replacement patterns are documented: - Placing a custom advisor inside the tool-call loop (order > `ToolCallingAdvisor.DEFAULT_ORDER) to observe every iteration via a side channel - Disabling the auto-registered advisor with AdvisorParams.toolCallingAdvisorAutoRegister(false) and driving the loop manually. Integration tests for the manual pattern are added . Upgrade notes for 2.0.0 GA cover impact and migration steps. Fix AbstractToolSearchToolCallingAdvisorIT Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
tzolov
force-pushed
the
remove-stream-tool-call-responses
branch
from
cede45c to
085efd3
Compare
Member
|
The module |
Member
|
Rebased, merged along with the test fixes via a753fde |
sdeleuze
changed the title
streamToolCallResponses from advisor builders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When streamToolCallResponses=true, tool-call request chunks were streamed downstream without the paired ToolResponseMessage, corrupting any downstream memory advisor's conversation history. The flaw cannot be fixed cleanly, so the option is removed from ToolCallingAdvisor, ToolCallAdvisor, and ToolSearchToolCallingAdvisor builders along with the corresponding auto-configuration properties.
Two replacement patterns are documented:
Integration tests for the manual pattern are added . Upgrade notes for 2.0.0 GA cover impact and migration steps.