Fix OpenAI streaming tool-call chunks with empty ids#6369
Open
ultramancode wants to merge 1 commit into
Open
Conversation
Signed-off-by: Taewoong Kim <ktw2172@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4790.
This fixes streaming tool-call merging when an OpenAI-compatible provider sends
continuation chunks with
id: "".OpenAiChatModel.ChunkMergerpreviously treated any present tool-call id as anew tool-call boundary. With an empty id, that could leave a partial tool call
without a function name and fail with
NoSuchElementExceptionwhile convertingthe merged chunk.
This update treats only non-empty ids as a new tool-call boundary, so empty-id
chunks follow the same continuation path as chunks where the id is omitted.