Skip to content

Replace deprecated JsonNode methods#6351

Open
guanxuc wants to merge 1 commit into
spring-projects:mainfrom
guanxuc:cleanup-depreacated
Open

Replace deprecated JsonNode methods#6351
guanxuc wants to merge 1 commit into
spring-projects:mainfrom
guanxuc:cleanup-depreacated

Conversation

@guanxuc

@guanxuc guanxuc commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace JsonNode.asText() with asString() and isTextual() with isString().

@guanxuc guanxuc force-pushed the cleanup-depreacated branch from 911d52a to 6a43416 Compare June 9, 2026 09:36
@guanxuc guanxuc changed the title * Replace deprecated JsonNode methods and null-safe annotations Replace deprecated JsonNode methods and null-safe annotations Jun 9, 2026
@guanxuc guanxuc force-pushed the cleanup-depreacated branch from 6a43416 to c6ce5e7 Compare June 9, 2026 09:45
@ericbottard ericbottard self-requested a review June 9, 2026 16:04
@ericbottard ericbottard self-assigned this Jun 9, 2026
@guanxuc guanxuc force-pushed the cleanup-depreacated branch 3 times, most recently from 04ffb1c to b0a7b25 Compare June 11, 2026 00:33
@sdeleuze sdeleuze added this to the 2.0.x milestone Jun 11, 2026
sdeleuze added a commit to sdeleuze/spring-ai that referenced this pull request Jun 11, 2026
@sdeleuze

Copy link
Copy Markdown
Contributor

@guanxuc Good catch, I have performed the null-safety changes via #6388 in order to ship them as part of 2.0.0, please rebase and rework this PR to focus on the JsonNode changes.

@sdeleuze sdeleuze changed the title Replace deprecated JsonNode methods and null-safe annotations Replace deprecated JsonNode methods Jun 11, 2026
- Replace JsonNode.asText() with asString() and isTextual() with isString().
- Replace org.springframework.lang with org.jspecify.annotations null-safe annotations.
- Make package org.springframework.ai.image.observation null-safe.

Signed-off-by: guanxu <1510424541@qq.com>
@guanxuc guanxuc force-pushed the cleanup-depreacated branch from b0a7b25 to 66f88eb Compare June 11, 2026 08:04
@guanxuc

guanxuc commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Hi, @sdeleuze
Thanks for your review and important notification, I have rebase the latest main branch and rework this PR to focus on the JsonNode changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants