Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

Intext 201#5

Open
fbalicchia wants to merge 5 commits into
spring-attic:masterfrom
fbalicchia:INTEXT-201
Open

Intext 201#5
fbalicchia wants to merge 5 commits into
spring-attic:masterfrom
fbalicchia:INTEXT-201

Conversation

@fbalicchia

Copy link
Copy Markdown
Contributor

Hi @artembilan

I applied damiendallimore commit and follow your notes.

Here a list of done task

  • now splunk-server-ref is optional and not mandatory cause HEC doesn't required
  • change attribute from camel to dash style
  • cleanup gradle.properties
  • try to apply spring framework Code-Style ;-)
  • replace stringBuffer with stringBuilder cause in this case may be fine

At the moment I haven't replace hecPost call with RestTemplate but in the near future IMHO
outboundChannelAdapter need to be reafactor cause index and tcp outbund adapters are legacy

@artembilan

Copy link
Copy Markdown
Contributor

Wow! Cool!
Thank you very much @fbalicchia !

I can't find the time to tickle @damiendallimore 's work properly. But my idea was to merge it as this with those simple polishing and rework to the restTemplate in the separate PR to have more proper review flow.
So, right now we have to close #3 in favor of this one and go ahead with review here! 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants