Open index files in binary mode when loading - #137
Open
Hashim1999164 wants to merge 1 commit into
Open
Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
FileInputStream used fopen text mode, which can alter bytes on Windows and make Index.load(path) report a corrupt index while loading the same file via an rb file object works. Also save path indexes in one write so metadata is not dropped.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #97.
FileInputStreamopened files with text modefopen, which can rewrite bytes on Windows. That madeIndex.load(path)fail with a corrupt index error even though the same bytes loaded fine through a Pythonrbfile object. Reads now use binary mode, matchingFileOutputStream. Path basedsavealso writes metadata and the index in a single pass instead of writing an index only file first.Test plan
Index.loadfunction exhibits unexpected behavior with filename:str argument #97 save thenIndex.load(path)flow locallypytest python/tests/test_load_indices.py python/tests/test_index_creation.py(4223 passing)