Open
Conversation
szykol
reviewed
Apr 27, 2026
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
from
5ddc2c2 to
bc51c97
Compare
Ickerday
changed the title
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
from
bc51c97 to
4e405a1
Compare
szykol
reviewed
Apr 28, 2026
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
from
4e405a1 to
f9b8a78
Compare
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
3 times, most recently
from
a8bbeca to
1bcf46c
Compare
Member
|
Is this PR fully automatic, or are here any manual changes? Its hard for me to review this change. Please update the PR description to include such details what this change does. The best way to approach such changes is to separate these i.e. one PR (or just commit) that does a format and second that does changes to fix say lint issues required to enable it in CI, otherwise such PRs require huge review burden to get through merging it. Since now this change requires a review of every single file, instead of just the 2nd PR/commit and it is super easy to miss important changes, that are not related to formatting changes. |
mateusz834
reviewed
Apr 30, 2026
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
3 times, most recently
from
8d89f97 to
b6d27ce
Compare
Ickerday
changed the title
szykol
reviewed
May 7, 2026
Comment on lines
+29
to
+30
| # $(UV_RUN_CMD) basedpyright | ||
| # $(UV_RUN_CMD) ruff check --fix-only |
Collaborator
Author
There was a problem hiding this comment.
I wanted to reenable those in the next PR if possible
szykol
reviewed
May 7, 2026
| .PHONY: ci-lint-python | ||
| ci-lint-python: | ||
| $(UV_RUN_CMD) basedpyright | ||
| # $(UV_RUN_CMD) basedpyright |
szykol
approved these changes
May 7, 2026
mateusz834
approved these changes
May 7, 2026
Ickerday
force-pushed
the
chore/adjust-linter-formatter-config
branch
from
b6d27ce to
b583b21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.