[Spike] Consume Noah-enabled splunk-ansible through the normal image build - #733
Draft
vivekr-splunk wants to merge 4 commits into
Draft
[Spike] Consume Noah-enabled splunk-ansible through the normal image build#733vivekr-splunk wants to merge 4 commits into
vivekr-splunk wants to merge 4 commits into
Conversation
vivekr-splunk
force-pushed
the
spike/noah-role-specific-client
branch
from
August 26, 2026 19:23
5504d13 to
f40dbdf
Compare
vivekr-splunk
force-pushed
the
spike/noah-role-specific-client
branch
from
August 26, 2026 19:25
f40dbdf to
831c08f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review stack
Why
The earlier spike image copied selected Ansible task files and patched
main.ymlandenviron.pyinside a derived Dockerfile. That made the image work, but hid the real provisioning implementation from reviewers.This PR now uses the standard docker-splunk build contract:
make ansiblefetches one immutable splunk-ansible commit, and the normal Splunk Dockerfile copies that complete tree into/opt/ansible.What changes
SPLUNK_ANSIBLE_REFtobb5321b2dc1ce6fbfb29937013afbf4feb5f10b5, the head of draft PR #925.splunk-ansibletree.The final diff contains only
docker-splunk/Makefileanddocker-splunk/tests/test_ansible_ref.py. It does not contain a gitlink change, a selected-file overlay, Python patching of Ansible files, account IDs, or credentials.Build flow
make ansiblecloneshttps://github.com/splunk/splunk-ansible.gitwhen the checkout is absent.SPLUNK_ANSIBLE_REFin detached mode.splunk-ansible/version.txt.splunk/common-files/DockerfileexecutesCOPY splunk-ansible ${SPLUNK_ANSIBLE_HOME}, so all Noah role files and tests come from the reviewed Ansible commit.Validation
python3 -m pytest -q -p no:cacheprovider docker-splunk/tests/test_ansible_ref.py: 5 passed.make ansibleusing this Makefile.version.txtboth resolved tobb5321b2dc1ce6fbfb29937013afbf4feb5f10b5.This remains a draft spike PR while the resulting image and the SOK runtime stack are validated end to end on the supported Kubernetes environments.