Skip to content

fix!: restore action-selected Git authentication - #64

Merged
phantom-jacob merged 3 commits into
mainfrom
sodle/restore-git-override-auth
Sep 22, 2026
Merged

phantom-jacob merged 3 commits into
mainfrom
sodle/restore-git-override-auth

Conversation

@sodle-splunk

@sodle-splunk sodle-splunk commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Bug Fixes

  • Restore asset access-token or username/password authentication when an action selects a different HTTP(S) Git remote.
  • Restore noninteractive SSH connections that accept previously unknown host keys when no optional verification feature exists.
  • Remove the mandatory ssh_host_key asset field and its fail-closed behavior.

Breaking Changes

  • Action-selected Git remotes again receive the asset's configured credentials.
  • The ssh_host_key asset field is removed and SSH host-key verification is no longer mandatory.
  • Both functional commits use fix!: and a BREAKING CHANGE: trailer so semantic-release selects a major version.

Manual Documentation

  • Generated connector documentation was updated to remove the mandatory ssh_host_key field.

Validation

  • pre-commit run --all-files --show-diff-on-failure
  • Python syntax compilation for git_connector.py and git_consts.py
  • Legacy BaseConnector repository: no connector-local unit-test module was added.
  • GitHub pre-commit and compile checks passed on the exact PR head.

Follow-up

  • PAPP-38472 tracks optional host-key verification at both asset and action levels while preserving existing behavior when neither value is supplied.

Other information

  • The skip-integration label intentionally suppresses asset-lab integration and sanity jobs.
  • Merge strategy: merge commit only; do not squash.
  • Written by Codex.

Please refer to our Contribution Guide for any questions on submitting a pull request.

Thanks for contributing!

Update the pinned connector development hooks before the functional change.

Written by Codex.
Action-level repository overrides now continue to use configured asset access tokens or username/password, matching high-trust SOAR connector behavior.

BREAKING CHANGE: action-selected Git remotes again receive the asset's configured credentials.

Written by Codex.
Remove mandatory pinned host-key configuration so headless Git SSH connections continue to accept previously unknown hosts.

BREAKING CHANGE: the ssh_host_key asset field is removed and SSH connections no longer require a pinned host key.

Written by Codex.
@sodle-splunk sodle-splunk added splunk-supported skip-integration Skip asset-lab integration jobs for this PR labels Sep 22, 2026
@github-actions

Copy link
Copy Markdown

Merging this PR will release 6.0.0 with the following release notes:

6.0.0 (2026-09-22)

⚠ BREAKING CHANGES

  • the ssh_host_key asset field is removed and SSH connections no longer require a pinned host key.

Written by Codex.

  • action-selected Git remotes again receive the asset's configured credentials.

Written by Codex.

Bug Fixes

  • restore asset auth for action remotes (04e69a5)
  • restore noninteractive SSH behavior (296bdf9)

Connector release changes

  • Restore asset authentication for action-selected Git remotes.
  • Restore noninteractive SSH connections without mandatory host-key verification.

@sodle-splunk
sodle-splunk marked this pull request as ready for review September 22, 2026 16:48
@phantom-jacob
phantom-jacob merged commit 99b92b4 into main Sep 22, 2026
10 of 18 checks passed
@phantom-jacob
phantom-jacob deleted the sodle/restore-git-override-auth branch September 22, 2026 16:56
@splunk-soar-semantic-release

Copy link
Copy Markdown

🎉 This PR is included in version 6.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released skip-integration Skip asset-lab integration jobs for this PR splunk-supported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants