Skip to content

fix: reset Git request state per parameter - #63

Closed
sodle-splunk wants to merge 2 commits into
mainfrom
sodle/fix-git-parameter-state-leak
Closed

sodle-splunk wants to merge 2 commits into
mainfrom
sodle/fix-git-parameter-state-leak

Conversation

@sodle-splunk

@sodle-splunk sodle-splunk commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Bug Fixes

  • Rebuild the effective repository URL, repository name, branch, SSH mode, and access-token state from trusted asset configuration for every parameter dictionary.
  • Prevent a caller-selected URL retained from an earlier parameter dictionary from receiving the asset username/password when a later dictionary omits repo_url.
  • Preserve the existing endpoint-binding and strict SSH host-verification controls from PR fix: remediate Flashpoint connector findings #61.

Refs PSAAS-30533, VULN-93258, and FS-955.

Manual Documentation

  • I have verified that manual documentation has been updated where appropriate; this internal state-isolation change requires no manual documentation update.

Validation

  • pre-commit run --all-files passed locally and in GitHub Actions.
  • Python syntax compilation and the GitHub compile check passed.
  • PSIRT source-only validation returned FIXED (code review) for exact head e010da63f46a6ee22bf8424642af3993c812309a and was recorded on VULN-93258.
  • No reported-scope regression test exists in this legacy connector; integration and sanity jobs are intentionally skipped by the skip-integration label.

Other information

  • The policy-correct read_only metadata is unchanged.
  • Merge strategy: merge commit only; do not squash.
  • Written by Codex.

Please refer to our Contribution Guide for any questions on submitting a pull request.

Thanks for contributing!

Update pre-commit hook revisions before the functional connector change.

Written by Codex.
Refs PSAAS-30533, VULN-93258, and FS-955.

Rebuild repository and credential state from trusted asset configuration for every parameter dictionary so a previous caller URL cannot receive stored credentials.

Written by Codex.
@sodle-splunk sodle-splunk added the skip-integration Skip asset-lab integration jobs for this PR label Sep 22, 2026
@github-actions

Copy link
Copy Markdown

Merging this PR will release 5.0.2 with the following release notes:

5.0.2 (2026-09-22)

Bug Fixes

  • reset Git request state per parameter (e010da6)

Connector release changes

  • Reset per-parameter repository state before applying asset credentials.

@sodle-splunk
sodle-splunk marked this pull request as ready for review September 22, 2026 16:12
@sodle-splunk

Copy link
Copy Markdown
Contributor Author

Closing in favor of a replacement PR that restores per-action remote selection with asset credentials and makes SSH host-key verification non-mandatory. Written by Codex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-integration Skip asset-lab integration jobs for this PR splunk-supported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant