Repository navigation
Conversation
splitshotz
left a comment
There was a problem hiding this comment.
Thanks, the change itself is small and tidy, and CI is green. I found a way it can lose a recording, so it can't go in as it is.
-
A clip save can swallow a session file.
_gsr_replay_candidatestells Vice's own files from a fresh replay only by theVice_Clip_andVice_Session_prefixes. With a template, a session file created while a clip save is waiting for its replay looks like the replay, gets renamed to a clip name and is trimmed to the clip length. I reproduced it with the realGSRRecorder.save_clipand the templaterec_$n: an 8 second sessionrec_1.mp4came back as a 2 secondrec_2.mp4, andrec_1.mp4was gone. The window is usually a fraction of a second, but it's 20 seconds when the recorder is slow to flush. Please leave the recorder's own session path out of the candidates instead of relying on a prefix. -
A clip and a session can be given the same name.
_next_session_pathreturns a name, but the file only exists once the capture process creates it, and a clip renamed in that gap gets the same path. Withrec_$nboth came back asrec_1.mp4, and withclip_$date_$timeboth got the same minute. Please reserve the name when it's handed out (create it withO_EXCL, or keep a set of reserved names that the clip naming also checks). -
French, German, Indonesian and Portuguese still say "Clip filename" and "clip number" for the two strings you changed. They have their own text, so there's no fallback to English. Those need the old keys removed or updated.
One thing I still have to decide: this renames sessions for everyone who already set a template, and with something like clip_$date_$time a session can no longer be told from a clip by its name. I may want it as its own switch. I'll answer here once 1 and 2 are fixed.
Summary
Session recordings now follow the same filename template as clips. Clip and session filename supports
$n,$date,$time, and$gamefor both, with a shared numbering sequence.Leaving the template empty keeps the existing clip and session defaults. Unusable templates fall back to those defaults, and existing recordings are never overwritten. Custom-named sessions keep their session metadata and start-time game identity.
Testing