Skip to content

Exclude processes from automatic session recording - #306

Draft
milan483 wants to merge 6 commits into
splitshotz:mainfrom
milan483:milan/auto-session-process-exclusions
Draft

milan483 wants to merge 6 commits into
splitshotz:mainfrom
milan483:milan/auto-session-process-exclusions

Conversation

@milan483

@milan483 milan483 commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Depends on #303.

Exclusion-only changes: compare with #303’s branch.

Summary

Adds Exclude processes from automatic sessions under Settings → Recording, with one process name per line. This lets users keep Steam software or other unwanted processes from triggering the automatic recording introduced in #303.

Names match exactly, ignoring case. The list defaults to empty, so existing behavior stays the same until entries are added. Saving changes does not restart capture. Manual recording, active sessions, game tagging, playlists, and Discord presence are unchanged.

This is limited to automatic starts for now. Input on whether app exclusions should eventually be shared with other game-detection features?

Testing

  • All 102 focused tests passed, covering exact matching, configuration persistence, candidate selection, two consecutive detections, live edits, current-process checks, PID reuse, and manual and active sessions.
  • Full discovery ran 1,146 tests: 1,140 passed, four skipped, and two failed. The AV1-selection and default Chromium-flag failures are the same cases previously reproduced on upstream main.
  • TypeScript checking, locale checks, and the UI build passed, including the settings round-trip test. No dependencies were added.
  • A live KDE Wayland check confirmed that Porthole did not start a session when porthole was excluded, while non-excluded Project Zomboid still started automatically. The original exclusion list was restored afterward.
  • Follow-up testing on the Exclude processes from automatic session recording #306 build passed an automated XFCE/X11 VM smoke test using ffmpeg and an installed Flatpak test using portal capture. Both verified process exclusions, automatic start/finalization, tags/highlights, and full video decoding. X11 sample frames passed automated non-black checks; host-side visual inspection was unavailable. Physical-GPU X11 gaming and audio were not tested.
  • Default screen/KMS capture with the per-user GPU Screen Recorder Flatpak remains blocked by a missing system KMS proxy. Running the recorder independently reproduced that failure; the portal configuration passed.

@milan483
milan483 marked this pull request as ready for review November 16, 2026 07:57

@splitshotz splitshotz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This depends on #303, so it waits for that one. Two things to fix here in the meantime:

  1. A process name longer than 15 characters never matches. The list is compared with /proc/<pid>/comm, which Linux cuts to 15 characters. I tried it with a real process: wallpaperengine64 in the list did not stop the session, wallpaperengine did. Nobody will guess that from "(Linux may truncate them)". Please compare the first 15 characters on both sides. It's the same trap as #262. Matching the window class or steam_app_<id> as well would help, since Steam software is the stated use.

  2. The API accepts things it shouldn't. Sending a string instead of a list answers ok: true and wipes the list. Non-strings are stored as their str() ({'a': 1} ended up in my config), and there's no limit on length or count. Please answer 400 to anything that isn't a list of strings, and cap both.

Smaller: the help text is three lines and reads like a spec, the box shows while auto-start is off, and the three new rows are now the first thing in the Recording card, above Buffer duration. I'd put them at the bottom of that card and only show the list when auto-start is on.

To your question: I'd keep exclusions to automatic sessions for now.

@milan483
milan483 marked this pull request as draft November 18, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants