Skip to content

fix: handle module buttons on either master half - #20

Merged
veypatch merged 1 commit into
splitkb:halcyon-qmkfrom
frankebel:fix-encoder-module
Aug 31, 2026
Merged

fix: handle module buttons on either master half#20
veypatch merged 1 commit into
splitkb:halcyon-qmkfrom
frankebel:fix-encoder-module

Conversation

@frankebel

Copy link
Copy Markdown

Disclaimer: I used an LLM to debug.

Fix module push buttons (knob press of the encoder-rev2 module)
being dropped when the button module's half is the slave.

  • rules.mk:
    Compile halcyon_buttons.c in every build.
    The button may only exist on the slave half.
    The master side needs to interpret the keycode.

  • halcyon_buttons.c:
    Select the button table from the event's matrix row
    (row < ROWS_PER_HAND = button lives on the left half).
    The old is_keyboard_left() is only correct if the left side is the master.

Tested on Halcyon Corne.

Closes #19.

@veypatch
veypatch changed the base branch from halcyon-qmk to halcyon August 31, 2026 10:17
@veypatch
veypatch changed the base branch from halcyon to halcyon-qmk August 31, 2026 10:17
@veypatch
veypatch merged commit 85577f7 into splitkb:halcyon-qmk Aug 31, 2026
@veypatch

Copy link
Copy Markdown
Collaborator

Thank you very much for the PR, that was indeed an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants