fix: handle module buttons on either master half - #20
Merged
Conversation
Collaborator
|
Thank you very much for the PR, that was indeed an oversight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: I used an LLM to debug.
Fix module push buttons (knob press of the encoder-rev2 module)
being dropped when the button module's half is the slave.
rules.mk:Compile
halcyon_buttons.cin every build.The button may only exist on the slave half.
The master side needs to interpret the keycode.
halcyon_buttons.c:Select the button table from the event's matrix row
(
row < ROWS_PER_HAND= button lives on the left half).The old
is_keyboard_left()is only correct if the left side is the master.Tested on Halcyon Corne.
Closes #19.